-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Declarative test setup #9283
Closed
Closed
Declarative test setup #9283
Changes from 10 commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
7f1ea61
only add declarative setup
npolshakova 4aec0e2
dedup helm values from declarative setup
npolshakova 6770aff
changelog
npolshakova 1ffaf1c
revert mergo version
npolshakova 754b868
move changelog
npolshakova c1ead87
regen
npolshakova 8c1f0d7
Merge refs/heads/main into npolshak/declarative-setup
soloio-bulldozer[bot] f17b956
Merge refs/heads/main into npolshak/declarative-setup
soloio-bulldozer[bot] 0793f9d
Adding changelog file to new location
a557d94
Deleting changelog file from old location
30589af
Merge remote-tracking branch 'origin/main' into npolshak/declarative-…
npolshakova 590c640
Merge refs/heads/main into npolshak/declarative-setup
soloio-bulldozer[bot] ef49794
pr feedback
npolshakova 88ce86c
Merge refs/heads/main into npolshak/declarative-setup
soloio-bulldozer[bot] 174e83e
Merge refs/heads/main into npolshak/declarative-setup
soloio-bulldozer[bot] b2b123c
Adding changelog file to new location
f8959bc
Deleting changelog file from old location
1b996a3
Merge refs/heads/main into npolshak/declarative-setup
soloio-bulldozer[bot] 92fa0ae
Merge refs/heads/main into npolshak/declarative-setup
soloio-bulldozer[bot] 6dfabef
Merge refs/heads/main into npolshak/declarative-setup
soloio-bulldozer[bot] 0b62590
Merge refs/heads/main into npolshak/declarative-setup
soloio-bulldozer[bot] 97fa5bb
Merge refs/heads/main into npolshak/declarative-setup
soloio-bulldozer[bot] a860944
Adding changelog file to new location
9ba2cfb
Deleting changelog file from old location
d0ce0c1
Merge refs/heads/main into npolshak/declarative-setup
soloio-bulldozer[bot] f784298
Merge refs/heads/main into npolshak/declarative-setup
soloio-bulldozer[bot] af0885e
Adding changelog file to new location
41acb20
Deleting changelog file from old location
7343ecc
Adding changelog file to new location
61270a7
Deleting changelog file from old location
286f7a3
Adding changelog file to new location
0737b0d
Deleting changelog file from old location
ee0db27
Adding changelog file to new location
c9c540b
Deleting changelog file from old location
8b43782
Adding changelog file to new location
a38e60e
Deleting changelog file from old location
8b5fee2
Adding changelog file to new location
bd8645c
Deleting changelog file from old location
11cc186
Adding changelog file to new location
ef3e849
Deleting changelog file from old location
8538828
Adding changelog file to new location
2d8eac7
Deleting changelog file from old location
db8e393
Adding changelog file to new location
a466f3e
Deleting changelog file from old location
f561fda
Adding changelog file to new location
cdc2c95
Deleting changelog file from old location
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
changelog: | ||
- type: NON_USER_FACING | ||
description: >- | ||
- Added declarative setup for setting up kind cluster, installing gloo and example applications to simplify e2e testing. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had imagined that the benefit for a declarative environment, is that the config we supply/declare is what defines what should be run. What if instead of having env variables that gate the steps, we just say the processor of the config says "if docker is to true, build the images", "if chart needs to be built, build the chart"...etc? That way we isolate complexity to this declarative setup?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I the separate docker/helm/declarative-setup is how GME handles it. I think it's possible to have the declarative setup also build the images/package the helm chart, but it's a little tricky because I think we'd want it to be identical to what we run in CI so we'd want to somehow reuse the make targets. I don't think it makes sense to hard code all the images/helm chart paths in the declarative setup code to do this since then that could drift.