Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DNM] Add net dial to portforward Start #9354

Closed
wants to merge 2 commits into from
Closed

[DNM] Add net dial to portforward Start #9354

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f63e69
add net dial to portforward Start to make sure we are available befor…
jbohanon Apr 11, 2024
912c10e
Merge refs/heads/main into jbohanon/kube-port-forward-race
soloio-bulldozer[bot] Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion pkg/utils/kubeutils/portforward/cli_portforwarder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,17 @@ type cliPortForwarder struct {

func (c *cliPortForwarder) Start(ctx context.Context, options ...retry.Option) error {
return retry.Do(func() error {
return c.startOnce(ctx)
err := c.startOnce(ctx)
if err != nil {
c.cmdCancel()
return err
}
_, err = net.Dial("tcp", fmt.Sprintf("%s:%d", c.properties.localAddress, c.properties.localPort))
if err != nil {
c.cmdCancel()
return err
}
return nil
}, options...)
}

Expand Down
Loading