Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install plugin to root home #82

Merged
merged 1 commit into from
Jul 20, 2020
Merged

Install plugin to root home #82

merged 1 commit into from
Jul 20, 2020

Conversation

oldsj
Copy link
Contributor

@oldsj oldsj commented Jul 10, 2020

Since we're running packer as root (with sudo), its expecting plugins to be installed in root's home, not the vagrant user's.
I was experiencing this issue without these changes when running vagrant provision --provision-with build-image :

default: Failed to initialize build 'arm-image': error initializing builder 'arm-image': Unknown builder arm-image

Since we're running packer as root (with sudo), its expecting plugins to be installed in root's home, not the vagrant user's.
I was experiencing this issue without these changes

```    default: Failed to initialize build 'arm-image': error initializing builder 'arm-image': Unknown builder arm-image```
@solo-build-bot
Copy link

Waiting for approval from someone in the solo-io org to start testing.

Copy link
Member

@yuval-k yuval-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't have vagrant to test, but this seems reasonable.
Thanks!

@yuval-k yuval-k merged commit 3ad2803 into solo-io:master Jul 20, 2020
crlane added a commit to crlane/packer-builder-arm-image that referenced this pull request Jul 30, 2020
- Resolves issue solo-io#83
- PR solo-io#82 introduced a change to plugin location, but did not update the
test of the plugins location. This resolves that and makes it a little
more general.
soloio-bulldozer bot pushed a commit that referenced this pull request Aug 12, 2020
* Repair plugin file creation and existence test

- Resolves issue #83
- PR #82 introduced a change to plugin location, but did not update the
test of the plugins location. This resolves that and makes it a little
more general.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants