Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Gloo Federation Go Types #243

Merged
merged 4 commits into from
Oct 6, 2021
Merged

Support Gloo Federation Go Types #243

merged 4 commits into from
Oct 6, 2021

Conversation

sam-heilbron
Copy link
Collaborator

@sam-heilbron sam-heilbron commented Oct 5, 2021 •
edited
Loading

Resolves: #106

@sam-heilbron sam-heilbron added the work in progress This pr is still being worked on label Oct 5, 2021
@sam-heilbron sam-heilbron changed the title [DNM] Support Gloo Federation Go Types Support Gloo Federation Go Types Oct 5, 2021
@sam-heilbron sam-heilbron removed the work in progress This pr is still being worked on label Oct 5, 2021
@sam-heilbron sam-heilbron marked this pull request as ready for review October 5, 2021 22:10
@jenshu
Copy link
Contributor

jenshu commented Oct 5, 2021

as part of this, could you remove these non user facing apis:

  • api/gloo-fed/fed.rpc
  • pkg/api/fed.rpc

@sam-heilbron
Copy link
Collaborator Author

Good call!

@soloio-bulldozer soloio-bulldozer bot merged commit 2fbec2e into gloo-master Oct 6, 2021
@soloio-bulldozer soloio-bulldozer bot deleted the sam/gloo-fed-go-types branch October 6, 2021 15:26
@sam-heilbron sam-heilbron mentioned this pull request Oct 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashleywang1 ashleywang1 ashleywang1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sam-heilbron @jenshu @ashleywang1