Fixed typo in the getting started docs #1
Merged
+22
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenfdev
commented
Jun 19, 2018
docs/getting_started/docker/1.md
Outdated
| @@ -159,7 +163,7 @@ Let's use `qlooctl` to register some resolvers. | |||
|
|
|||
| ```bash | |||
| # register findPetById for Query.pets (specifying no arguments) | |||
| qlooctl resolvermap register -u petstore -f findPetById Query pets | |||
| qlooctl resolvermap register -u petstore -f findPets Query pets | |||
There was a problem hiding this comment.
Wasn't sure if this was intended to be findPetById. If it was, I'll revert it.
There was a problem hiding this comment.
it so happens that without any parameters, this function will return the list of pets
|
thanks for this! just revert the |
This fixes typos related to: * Code formatting in markdown. Signed-off-by: Ken Fukuyama <kenfdev@gmail.com>
kenfdev
force-pushed
the
fix-gettings-started-docs-typo
branch
from
ceba1b0
to
3a94be3
Compare
|
@ilackarms Thanks for the review! I've reverted the changes for the function registeration. This PR only changes the markdown format. |
|
sure. thanks for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks for all the effort for this project. I'm starting to invest my time in using
qlooand have started from thegetting startedsection. It seemed like the markdown was corrupted and confused me a bit so have decided to create this PR.This fixes typos related to:
* The function registered forQuery.petswasfindPetByIdbut fixed tofindPetsSigned-off-by: Ken Fukuyama kenfdev@gmail.com