moved everything and got dep to pass #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickducott
suggested changes
Feb 19, 2019
Gopkg.toml
Outdated
| revision = "6b3b338d5f9c8b5a80ad4ea1e2e37aa58677ea9d" | ||
| name = "github.com/vektah/gqlgen" | ||
|
|
||
| # this must match the version of the gqlgen binary we depend on |
There was a problem hiding this comment.
This comment suggests we should be pinning the gqlgen binary, which I don't see
There was a problem hiding this comment.
That comment has to do with the API server, it's left over. Sqoop does not use the binary
api/v1/resolver_map.proto
Outdated
| } | ||
|
|
||
| // A Go-template which will return data for a Resolver without making a function call. Template Resolvers can make use | ||
| // of Sqoop's builtin template functions as well as the data provided by the Params object to the resolver. | ||
| // Read more about Templates and Resolvers in Sqoop's [Resolver documentation](TODO). | ||
| // Read more about Templates and Resolvers in Sqoop\'s [Resolver documentation](TODO). |
There was a problem hiding this comment.
Remove TODO from proto because it will be published in our docs. (Remove all TODOs, if there are others). File issue to track instead.
api/v1/schema.proto
Outdated
| option (core.solo.io.resource).short_name = "sc"; | ||
| option (core.solo.io.resource).plural_name = "schemas"; | ||
| // TODO: remove when we are ready to include this resource in the docs | ||
| option (core.solo.io.resource).skip_docs_gen = true; |
ci/check-code-and-docs-gen.sh
Outdated
| exit 1; | ||
| fi | ||
|
|
||
| (cd projects/gloo/doc && make site -B) |
There was a problem hiding this comment.
This doesn't look right
mkdocs.yml
Outdated
| @@ -31,7 +31,7 @@ site_author: gloo Project Authors | |||
| copyright: © Copyright 2018, solo.io Inc. | |||
| google_analytics: ['UA-101654320-1', 'sqoop.solo.io'] | |||
There was a problem hiding this comment.
We need to switch to Hugo
test/testdata/utils.go
Outdated
| // resolverMap.Types["Query"].Fields["droid"].Resolver = &v1.Resolver_GlooResolver{ | ||
| // GlooResolver: &v1.GlooResolver{ | ||
| // RequestTemplate: `{"id": {{ index .Args "id" }}}`, | ||
| // Function: &v1.GlooResolver_SingleFunction{ |
| // createResolver func(typeName, fieldName string) (RawResolver, error) | ||
| // ) | ||
| // BeforeEach(func() { | ||
| // requestBody = &bytes.Buffer{} |
test/unit/gloo_resolvers_test.go
Outdated
| // | ||
| // "github.com/gorilla/mux" | ||
| // "github.com/solo-io/sqoop/pkg/api/v1" | ||
| // . "github.com/solo-io/sqoop/pkg/engine/resolvers/gloo" |
test/unit/router_test.go
Outdated
| package unit_test | ||
|
|
||
| //import ( | ||
| // . "github.com/onsi/ginkgo" |
rickducott
reviewed
Feb 21, 2019
| hack/create-release.sh github_api_token=$(GITHUB_TOKEN) owner=solo-io repo=sqoop tag=v$(VERSION) | ||
| @$(foreach BINARY,$(RELEASE_BINARIES),hack/upload-github-release-asset.sh github_api_token=$(GITHUB_TOKEN) owner=solo-io repo=sqoop tag=v$(VERSION) filename=$(BINARY);) | ||
| release: release-binaries release-yamls | ||
| ifeq ($(RELEASE),"true") |
There was a problem hiding this comment.
we could add the docs push in this PR or in a follow up
There was a problem hiding this comment.
err let's do it here, i see we have the script already
rickducott
reviewed
Feb 21, 2019
ci/check-code-and-docs-gen.sh
Outdated
| exit 1; | ||
| fi | ||
|
|
||
| (cd sqoop/doc && make site -B) |
rickducott
reviewed
Feb 21, 2019
| @@ -7,7 +7,7 @@ import ( | |||
| . "github.com/onsi/gomega" | |||
| ) | |||
|
|
|||
| func TestGloo(t *testing.T) { | |||
| func TestResolvermap(t *testing.T) { | |||
There was a problem hiding this comment.
nit: should be ResolverMap here and below
rickducott
reviewed
Feb 21, 2019
cli/pkg/helpers/clients.go
Outdated
| if err != nil { | ||
| return nil, errors.Wrapf(err, "getting kube config") | ||
| } | ||
| secretClient, err := glooV1.NewSecretClient(&factory.KubeSecretClientFactory{ |
There was a problem hiding this comment.
I think this needs KubeCoreCache
There was a problem hiding this comment.
Maybe, but I also don't use that code so I removed it
rickducott
approved these changes
Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.