Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace build timestamp with commit sha #223

Open
mitchdraft opened this issue Jun 19, 2019 · 1 comment
Open

replace build timestamp with commit sha #223

mitchdraft opened this issue Jun 19, 2019 · 1 comment

Comments

@mitchdraft
Copy link
Contributor

Ideally, separate builds from the same commit should produce identical artifacts

we have one known source of entropy:

squashctl --version
squashctl version 0.5.15, created 2019-05-14.23:26:51

Replace the timestamp with a commit sha

requested in #220
@scranton scranton mentioned this issue Jul 24, 2019
Merged
@bacongobbler
Copy link

looks like this can be closed (and perhaps #234 can be reverted) now that #231 was merged. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bacongobbler @mitchdraft