-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PIN support #20
Comments
Hi! |
I agree it would be nice to (more generally) have a framework to read Not sure how much more secure this is, won't most people type |
Sounds like a generic thing to do. I remember some CLI frameworks have such feature available - hasn't I think the idea back then was to avoid cluttering the shell's history with the raw PIN, which is written to user's hard drive in plaintext. I agree, that using |
I add change pin feature to solo tool. Please take a look |
might it not just be better to ask the PIN inside the running command? similar like ssh-keygen or whatever it was called does? because env vars are semi annoying to use and most importantly annoying when dealing with multiple keys when you have different PINs, also browsers and stuff probably have a reason why they always ask for the pin and not store it somewhere... |
There are two parts:
-p/--pin <PIN>
in all subcommands that might need itsolo pin set/reset
to set/change the PINThere is working code in
https://github.com/solokeys/solo/blob/master/tools/testing/tests/fido2.pyhttps://github.com/solokeys/fido2-tests/tree/master/tests/standard/fido2 to guide this.The actual code should be added to client.py, which the CLI just calls.
The text was updated successfully, but these errors were encountered: