clean up code: GCC warnings; add black to travis; fix linux build errors

[yparitcher]

fix some build errors on linux
clean up the build so only the appropriate parts are made for each build.
fixes all GCC warnings

[nickray]

Are you sure about that GCC ARM ppa? Thanks a lot for looning into the Travis situation!

[yparitcher]

that is arm's official ppa it should be the same as the compilers directly from their website.
i force pushed one commit so Travis is not testing this pull request any more, so i cant be sure if it passes

[nickray]

Do you have a Solo Hacker? If so could you test the generated builds for each of

tools/solotool.py program targets/stm32l432/all.hex --use-dfu --detach
tools/solotool.py program targets/stm32l432/solo.hex

via some U2F test page?

The reason I'm pushing this is that I am on Debian so I can't test PPAs properly, but the outcome of #50 (comment) was that Debian's packages did not produce working HEX files while the ARM website downloads do (they both build).

[yparitcher]

the builds work on my computer using the ARM website downloads, as i only just found out about the ppa.
ubuntu and debian default package have a bug because incompatible versions of libraries were used in building the package
i have not tested the ppa but i can try it a little later.
what i was not sure about was the Travis config being set up 100%, however the code builds and runs on my solo, as a result of the bug-fixing i did

[nickray]

the builds work on my computer using the ARM website downloads, as i only just found out about the ppa.

ubuntu and debian default package have a bug because incompatible versions of libraries were used in building the package

nice!

i have not tested the ppa but i can try it a little later.

thank!

what i was not sure about was the Travis config being set up 100%, however the code builds and runs on my solo, as a result of the bug-fixing i did

Travis is a bit useless as is, so I'm happy to merge that part and we can iterate from there.

[nickray]

Would you be able to add something to Travis that runs black -S --check on the Python stuff that is not copy-pasted external code? You could build on the existing make env3 and make black targets, but note that we don't want to enforce using virtualenvs throughout the code (just helpfully make them available). If not, that's OK too :)

[nickray]

Oh, and can you point me to the Debian ARM package bug?

[yparitcher]

bug reports

• debian
• ubuntu

the venv stuff that i added is optional use like the prefix; just for the test i had set it so travis can use the python

the ppa toolchain builds the code, I will test flashing it later

[yparitcher]

Rebased on master

[nickray]

Thanks for all these fixes so far, @conorpp will review the C changes.

[pjz]

If you leave that dependency in, it should automatically check out the submodule if it's not there.

[yparitcher]

however it will then only rebuild Cbor if the makefile (which does not happen) changes even if you change architectures, which breaks builds

[pjz]

Changing architecture doesn't indicate a code change. I think if you're going to change architecture you just have to do a make clean first. If the current make clean doesn't clean tinycbor then that should be fixed, which would then allow this auto-checkout still work and an alternate architecture to build correctly after a make clean.

[yparitcher]

good point will fix

[yparitcher]

@pjz the makefile in general is overly complex, and not consistent and should probably be rewritten, however i tried to work around the existing structure. thanks for the review

[yparitcher]

Travis build finaly fixed with stm32l432 code built and black run on the python

[cla-bot]

We require contributors to sign our Copyright License Agreement, and we don't have @yparitcher on file. In order for us to review and merge your code, please visit https://solokeys.com/legal/contributors, or contact @nickray, @conorpp or @0x0ece for further information or help.

[yparitcher]

@nickray @conorpp @0x0ece Please review #77 and hopefully relicence under GPLv2 thereby using a solid open source licence without needing CLAs and other circumventions to the GPLv3 that put everything in the same spot with added hassle & contributors work are not totally open source.
Thanks

[cla-bot]

We require contributors to sign our Copyright License Agreement, and we don't have @yparitcher on file. In order for us to review and merge your code, please visit https://solokeys.com/legal/contributors, or contact @nickray, @conorpp or @0x0ece for further information or help.

[yparitcher]

Rebased on master

[yparitcher]

my commits in this pull request are licensed under the GPLv2 thereby resolving licensing issues.

[cla-bot]

We require contributors to sign our Copyright License Agreement, and we don't have @yparitcher on file. In order for us to review and merge your code, please visit https://solokeys.com/legal/contributors, or contact @nickray, @conorpp or @0x0ece for further information or help.

[conorpp]

I like getting rid of the warnings for sure, but I don't like adding

#if DEBUG_LEVEL > 0
...
#endif

for every unused variable. It's a bit messy, and I think it'd be better to leave/ignore the unused-related warnings.

[conorpp]

Sorry for taking a long time to get around to this. Could you take a look at the conflicts? Also would it be okay to dual license under MIT+Apache2? Just updated the license for the repo.

[cla-bot]

We require contributors to sign our Copyright License Agreement, and we don't have @yparitcher on file. In order for us to review and merge your code, please visit https://solokeys.com/legal/contributors, or contact @nickray, @conorpp or @0x0ece for further information or help.

[cla-bot]

We require contributors to sign our Copyright License Agreement, and we don't have @yparitcher on file. In order for us to review and merge your code, please visit https://solokeys.com/legal/contributors, or contact @nickray, @conorpp or @0x0ece for further information or help.

[yparitcher]

MIT+Apache2 is fine

[yparitcher]

Please remove the cla-bot

[yparitcher]

let me know if i need to change anything

[conorpp]

Looks good, thanks!!