Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1224]: Improving twig template debugging for formatting templates #1255

Merged
merged 2 commits into from
May 3, 2024

Conversation

gustavs-gutmanis
Copy link
Contributor

Related Ticket Number

#1224

Description

When an error is encountered during the rendering of a Freeform Form formatting template, a cryptic error message was thrown, without displaying the template file's line and surrounding code. Instead a single string of a compiled template is shown. This was due to the use of ::renderString method, rather than ::renderTwig method.

  • switching from ::renderString to ::renderTemplate when rendering formatting templates

@gustavs-gutmanis gustavs-gutmanis self-assigned this May 1, 2024
@gustavs-gutmanis gustavs-gutmanis added the refactor Refactor an existing functionality label May 1, 2024
@kjmartens kjmartens merged commit 053b80a into v5 May 3, 2024
4 checks passed
@kjmartens kjmartens deleted the refactor/render-string branch May 3, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactor an existing functionality
Development

Successfully merging this pull request may close these issues.

None yet

2 participants