Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: covariance possible issues #21

Merged
merged 6 commits into from Jul 10, 2020
Merged

Conversation

belgattitude
Copy link
Member

@belgattitude belgattitude commented Jul 10, 2020

  • Update Q&A (psalm/phpstan)
  • ProcessExceptionInterface: prevent covariance issues
  • NullCache: fixed minor issue with latest phpstan:
 ------ -------------------------------------------------------------------- 
  Line   src/Common/Cache/NullCache.php                                      
 ------ -------------------------------------------------------------------- 
  40     Return type (mixed) of method                                       
         Soluble\MediaTools\Common\Cache\NullCache::getMultiple() should be  
         covariant with return type (iterable) of method                     
         Psr\SimpleCache\CacheInterface::getMultiple()                       
 ------ -------------------------------------------------------------------- 
  • Added changelog entries

@codecov
Copy link

codecov bot commented Jul 10, 2020

Codecov Report

Merging #21 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #21   +/-   ##
=========================================
  Coverage     98.06%   98.06%           
  Complexity      680      680           
=========================================
  Files            51       51           
  Lines          1448     1448           
=========================================
  Hits           1420     1420           
  Misses           28       28           
Impacted Files Coverage Δ Complexity Δ
src/Common/Cache/NullCache.php 100.00% <ø> (ø) 9.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb6d494...4a3490e. Read the comment docs.

@belgattitude belgattitude merged commit dd18cc6 into master Jul 10, 2020
@belgattitude belgattitude deleted the fix/mixed-return-type branch July 10, 2020 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant