Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed macos build failed #97

Merged
merged 1 commit into from
Dec 18, 2021
Merged

fix: fixed macos build failed #97

merged 1 commit into from
Dec 18, 2021

Conversation

j8xixo12
Copy link
Collaborator

Added macOS's sed into bzip2 build script to fix build failed issue

@j8xixo12 j8xixo12 self-assigned this Dec 18, 2021
@yungyuc yungyuc added bug Something isn't working fix fix bug and removed bug Something isn't working labels Dec 18, 2021
@yungyuc yungyuc merged commit eaac111 into solvcon:main Dec 18, 2021
@yungyuc
Copy link
Member

yungyuc commented Dec 18, 2021

Thanks for the instant fix. This is quite an interesting difference of sed between mac and linux!

@tai271828 tai271828 mentioned this pull request Dec 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yungyuc yungyuc yungyuc approved these changes

@tai271828 tai271828 Awaiting requested review from tai271828

Assignees

@j8xixo12 j8xixo12

Labels
fix fix bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@j8xixo12 @yungyuc