Remove the Python text box at the right-hand side #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change all applications to set the Python command line instead.
yungyuc
commented
Nov 6, 2022
| @@ -9,7 +9,6 @@ set(MODMESH_VIEW_HEADERS | |||
| ${CMAKE_CURRENT_SOURCE_DIR}/RAxisMark.hpp | |||
| ${CMAKE_CURRENT_SOURCE_DIR}/RMainWindow.hpp | |||
| ${CMAKE_CURRENT_SOURCE_DIR}/RPythonConsoleDockWidget.hpp | |||
| ${CMAKE_CURRENT_SOURCE_DIR}/RPythonText.hpp | |||
| m_pycon = new RPythonConsoleDockWidget(QString("Console"), this); | ||
| m_pycon->setAllowedAreas(Qt::BottomDockWidgetArea | Qt::TopDockWidgetArea); | ||
| m_pycon->setAllowedAreas(Qt::AllDockWidgetAreas); |
There was a problem hiding this comment.
Allow narrow command line dock on left and right.
| "command", | ||
| [](wrapped_type const & self) | ||
| { | ||
| return self.command().toStdString(); |
There was a problem hiding this comment.
Later when we have sufficiently many such wrappers, we should add a caster for QString.
There was a problem hiding this comment.
maybe open an issue, otherwise it's easy to forget lol
There was a problem hiding this comment.
Sounds like a good idea. After filing one could you tag it here?
| # Need to hold the win object to keep PySide alive. | ||
| win, svr = mm.app.bad_euler1d.run(animate=True, interval=10) | ||
| """.lstrip() | ||
| cmd = "win, svr = mm.app.bad_euler1d.run(animate=True, interval=10)" |
There was a problem hiding this comment.
pycon takes a one liner. It does not yet have a check in the engine so that we can fine-tune the implementation.
|
@tigercosmos I am merging and would like you have your comments. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change all applications to set the Python command line instead.
Ref #104