build(Makefile): make python3-config protable #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using python virtual environment, python-config or python3-config are maybe not included in PATH, and thus the command may return incorrect information of python configuration.
yungyuc
reviewed
Dec 10, 2022
yungyuc
requested changes
Dec 10, 2022
yungyuc
requested changes
Dec 10, 2022
tai271828
commented
Dec 10, 2022
|
I would encourage you to make sure CI passes in your fork before filing a PR. |
We should not allow any possibility of running Python 2.
This is a good idea. I will do that next time. |
By using cmake native helpers, e.g. get_filename_component, we can make sure the job able to run across platforms.
using make functions while we can since it runs faster than shell
|
Updated the pull request according to the above comments and suggestions. Ready to review again. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using python virtual environment, python-config or python3-config are maybe not included in PATH, and thus the command may return incorrect information of python configuration.