Add code to build the data for 2D unstructured mesh object #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… object This is the first step: Create a simple test function for the object creation.
yungyuc
added this to new
in Support multi-dimensional unstructured mesh
via automation
yungyuc
moved this from todo
to inprogress
in Support multi-dimensional unstructured mesh
yungyuc
changed the title
Closed
Note that the cell type ID is augmented by 1 (the valid type ID started from 0 in SOLVCON, but now it starts from 1 in modmesh). Use of 1-based index leaves 0 to be the invalid sentinel for the type ID in modmesh. Use the trivial triangle unit tests for build_faces_from_cells().
Ref issue solvcon#34.
This was referenced Dec 31, 2021
Closed
Closed
Ref issue solvcon#35.
Also include porting count_ghost() and fill_ghost(). Ref issue solvcon#36. Copy code from SOLVCON: https://github.com/solvcon/solvcon/blob/8dd74fa848b8d14d7796138ce199d0ae2e70235f/libmarch/include/march/mesh/UnstructuredBlock/class.hpp#L312.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress:
build_faces_from_cells()from SOLVCON. Copy the code from https://github.com/solvcon/solvcon/blob/8dd74fa848b8d14d7796138ce199d0ae2e70235f/libmarch/include/march/mesh/UnstructuredBlock/build_faces_from_cells.hpp. Only tested with a trivial 2D mesh.calc_metric()from SOLVCON. Copy the code from https://github.com/solvcon/solvcon/blob/8dd74fa848b8d14d7796138ce199d0ae2e70235f/libmarch/include/march/mesh/UnstructuredBlock/calc_metric.hpp. Only tested with a trivial 2D mesh.build_boundary()from SOLVCON. Copy the code from https://github.com/solvcon/solvcon/blob/8dd74fa848b8d14d7796138ce199d0ae2e70235f/libmarch/include/march/mesh/UnstructuredBlock/class.hpp#L388. Only tested with a trivial 2D mesh.build_ghost()from SOLVCON. Copy the code from https://github.com/solvcon/solvcon/blob/8dd74fa848b8d14d7796138ce199d0ae2e70235f/libmarch/include/march/mesh/UnstructuredBlock/class.hpp#L312. Only tested with a trivial 2D mesh.