Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry failed S3 uploads when the connection is reset by a proxy #291

Closed
davecap opened this issue Jan 28, 2019 · 0 comments · Fixed by #292
Closed

Retry failed S3 uploads when the connection is reset by a proxy #291

davecap opened this issue Jan 28, 2019 · 0 comments · Fixed by #292
Labels
enhancement P1:high

Comments

@davecap
Copy link
Member

davecap commented Jan 28, 2019

In some cases, the PUT request to S3 will fail due to an intermediate proxy server resetting the connection. We should add a session with retries for the S3 PUT request just like we do for the client module.

https://github.com/solvebio/solvebio-python/blob/master/solvebio/resource/object.py#L224
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement P1:high
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Retry uploads up to 5 times solvebio/solvebio-python
1 participant
@davecap