Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

object.tag() clear existing tags in solvebio 2.11.0 #347

Closed
PolinaBevad opened this issue Jul 9, 2020 · 1 comment · Fixed by #353
Closed

object.tag() clear existing tags in solvebio 2.11.0 #347

PolinaBevad opened this issue Jul 9, 2020 · 1 comment · Fixed by #353
Assignees

Comments

@PolinaBevad
Copy link
Contributor

Hi @jsh2134, @davecap,

I used 2.9.0 previously, so didn't find this before.
If I try to use object.tag() to remove tags in solvebio-python 2.11.0, all object tags are cleaned up.

Example of the code:

obj = dataset.vault_object  # dataset has tags 'current', 'OAPL' etc.
obj.tag(['current'], remove=True, apply_save=True) 
print(obj.tags)   # here it will be empty

The reason is here: https://github.com/solvebio/solvebio-python/blob/master/solvebio/resource/object.py#L504
Old tags rewritten by updated_tags. Maybe set difference operation can be used here?
Thank you!

@jsh2134 jsh2134 self-assigned this Jul 9, 2020
@nikolamaric nikolamaric self-assigned this Jul 29, 2020
@jsh2134
Copy link
Contributor

jsh2134 commented Jul 31, 2020

This change will be included in the next release

@jsh2134 jsh2134 added this to the Release v2.12.0 milestone Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants