Object tagging updates #353

nikolamaric · 2020-07-30T10:08:25Z

fixes tag removal bug (resolves object.tag() clear existing tags in solvebio 2.11.0 #347 )
change <object>.tag(my_tag) command to save the tag by default (previously apply_save=False by default)
add a shortcut untag() that removes a tag
allow a single tag in the tag() and untag() commands (previously required a list)
docs available here https://docs.solvebio.com/vaults/basics/#metadata-and-tags

solvebio/resource/object.py

Nikola added 2 commits July 29, 2020 15:33

Add additional logic for updated_tags list

4918ad6

Add untag method and unit tests for removing tags and untagging.

7705466

nikolamaric requested a review from jsh2134 July 30, 2020 10:08

Add minor changes to test_object_untag unit test

2279276

jsh2134 suggested changes Jul 30, 2020

View reviewed changes

solvebio/resource/object.py Outdated Show resolved Hide resolved

Remove partial

9ab9c79

nikolamaric requested a review from jsh2134 July 30, 2020 14:51

Nikola and others added 2 commits July 30, 2020 17:06

flake8

e7022a4

change apply_save default value to True

967f225

jsh2134 requested a review from davecap July 30, 2020 16:19

davecap approved these changes Jul 30, 2020

View reviewed changes

davecap reviewed Jul 30, 2020

View reviewed changes

solvebio/resource/object.py Show resolved Hide resolved

Check whether 'tags' param is iterable and add unit test for that

e112da1

jsh2134 reviewed Jul 30, 2020

View reviewed changes

solvebio/resource/object.py Outdated Show resolved Hide resolved

Rename the helper function

ebabb29

nikolamaric requested a review from jsh2134 July 30, 2020 20:38

jsh2134 approved these changes Jul 31, 2020

View reviewed changes

jsh2134 changed the title ~~Issue 347 object tag clear all tags~~ Object tagging updates Jul 31, 2020

nikolamaric merged commit d94f233 into master Jul 31, 2020

nikolamaric deleted the issue-347-object-tag-clear-all-tags branch July 31, 2020 16:05

Provide feedback