add reader_params #216
Merged
add reader_params #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
actually will not support this right now since the |
|
actually this may not be the case. this needs to be confirmed. |
|
ready for review. API now correctly supports all the manifest parameters, supports pulling them from DatasetImport if not defined in the manifest AND supports overriding them per file in the manifest should someone have a case where they want to do that. |
davecap
reviewed
Jan 23, 2018
solvebio/resource/manifest.py
Outdated
| 'md5': kwargs.get('md5'), | ||
| 'base64_md5': kwargs.get('base64_md5') | ||
| }) | ||
| manifest_item = dict(url=url) |
There was a problem hiding this comment.
Minor point but dict(url=url, **kwargs) should work
davecap
approved these changes
Jan 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #214