Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to "create-dataset" and "import" shortcut commands #321

Merged
merged 12 commits into from Feb 21, 2020
Merged

Updates to "create-dataset" and "import" shortcut commands #321

merged 12 commits into from Feb 21, 2020

Conversation

jsh2134
Copy link
Contributor

@jsh2134 jsh2134 commented Feb 17, 2020

Create Dataset

  • pass --tag values to add tags to the dataset
  • pass --metadata vaults to add metadata key value paris
  • pass --metadata-json-file to pass a JSON file of complex metadata

Breaking Changes

  • fails if dataset already exists
  • remove vault and path command overrides. Complete transition to full_path

Import data command

  • Inherits all new features above for creating datasets (via --create-dataset)
  • pass --remote-source command toggles the file arguments to be remote paths

Breaking Changes

  • Inherits all breaking changes above for creating datasets (via --create-dataset)

@jsh2134 jsh2134 requested a review from davecap February 17, 2020 22:51
davecap
davecap approved these changes Feb 17, 2020
View reviewed changes
Copy link
Member

@davecap davecap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comments. Dry run mode would be great!

solvebio/cli/data.py
if args.metadata_json_file:
with open(args.metadata_json_file, 'r') as fp:
try:
metadata = json.load(fp)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any value in supporting YAML metadata files?

solvebio/cli/main.py Outdated Show resolved Hide resolved
davecap
davecap approved these changes Feb 20, 2020
View reviewed changes
solvebio/cli/data.py Outdated Show resolved Hide resolved
@jsh2134 jsh2134 merged commit 2a20046 into master Feb 21, 2020
@jsh2134 jsh2134 deleted the update-short-commands branch April 24, 2020 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davecap davecap davecap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jsh2134 @davecap