Object.get_or_create_by_full_path() #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecap
approved these changes
Apr 24, 2020
| except KeyError as err: | ||
| if name in valid_dataset_attrs and self.is_dataset: | ||
| return getattr( | ||
| Dataset(self.dataset_id, client=self._client), name) |
There was a problem hiding this comment.
why not getattr(self.dataset, name)
There was a problem hiding this comment.
we don't need to do the lookup to get the Dataset object in most cases. Wanted to avoid making the GET request if possible, which is why I used the instance.refresh() logic within those methods that needed them
There was a problem hiding this comment.
but then why not just not do the lookup in def dataset?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows creating nested paths on the fly, which currently requires way too many lines of code. Takes the existing Dataset.get_or_create_by_full_path() and moves and upgrades it.
Also closes #326
Also closes #287