Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a different fake dataset ID #378

Merged
merged 3 commits into from Dec 1, 2020
Merged

Use a different fake dataset ID #378

merged 3 commits into from Dec 1, 2020

Conversation

davecap
Copy link
Member

@davecap davecap commented Nov 25, 2020

No description provided.

@davecap davecap requested a review from jsh2134 November 25, 2020 16:12
jsh2134
jsh2134 suggested changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@jsh2134 jsh2134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests failing with Error (dataset_id): ['Incorrect type. Expected pk value, received unicode.']

@jsh2134 jsh2134 merged commit 5e4b549 into master Dec 1, 2020
@jsh2134 jsh2134 deleted the use-different-dataset-id branch December 1, 2020 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsh2134 jsh2134 jsh2134 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davecap @jsh2134