Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use styled props in Collapse component #1

Merged
merged 2 commits into from
May 10, 2022
Merged

fix: Use styled props in Collapse component #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21be11c
fix: Use styled props in Collapse component
mu-hun May 8, 2022
f946f76
chore: Rename to CollapseContainer
mu-hun May 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
33 changes: 21 additions & 12 deletions src/components/Collapse.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,28 @@
import React, { ReactHTML, useLayoutEffect, useRef, useState } from 'react'
import styled from 'styled-components'

export interface CollapseProps {
shown: boolean
children?: React.ReactNode
as?: keyof ReactHTML
}

interface RenderComponentProps {
height: number | 'auto'
opacity: number
}

const CollapseContainer = styled.div<RenderComponentProps>`
height: ${({ height }) => height};
transform-origin: top;
opacity: ${({ opacity }) => opacity};
transition: height 0.3s ease, opacity 0.3s ease;
pointer-events: ${({ opacity }) => (opacity ? 'all' : 'none')};
overflow: 'hidden';
`

export const Collapse: React.FC<CollapseProps> = (props) => {
const { as = 'div', shown, children } = props
const { as, shown, children } = props

const contentsRef = useRef<HTMLDivElement>(null)
const [contentHeight, setContentHeight] = useState<number>(0)
Expand Down Expand Up @@ -38,19 +53,13 @@ export const Collapse: React.FC<CollapseProps> = (props) => {
}
}, [shown, contentHeight])

const RenderComponent = as
return (
<RenderComponent
style={{
height: renderHeight,
transformOrigin: 'top',
opacity: prevShown || shown ? 1 : 0,
transition: `height .3s ease, opacity .3s ease`,
pointerEvents: prevShown || shown ? 'all' : 'none',
overflow: 'hidden',
}}
<CollapseContainer
as={as}
height={renderHeight}
opacity={prevShown || shown ? 1 : 0}
>
{mountChild ? <div ref={contentsRef}>{children}</div> : null}
</RenderComponent>
</CollapseContainer>
)
}