Skip to content
Permalink
Branch: master
Commits on Sep 20, 2019
  1. Make helix origin create a line even if it's in a different group.

    phkahler authored and whitequark committed Sep 20, 2019
    Helix should always make a line for the axis.
  2. Reimplement DivPivoting as DivProjected.

    phkahler authored and whitequark committed Sep 20, 2019
    The old implementation was an approximation, whereas the new one is exact.
Commits on Sep 11, 2019
  1. Calculate area of selected faces, if any.

    Evil-Spirit authored and whitequark committed Sep 11, 2019
  2. Clean up virtual, override, default, and void params. NFC.

    rpavlik authored and whitequark committed Sep 10, 2019
    Found by clang-tidy.
  3. Use emplace_back. NFC.

    rpavlik authored and whitequark committed Aug 20, 2019
    Found by clang-tidy.
  4. Don't call static methods through an instance. NFC.

    rpavlik authored and whitequark committed Aug 20, 2019
    Found by clang-tidy.
  5. Linux: add support for building snap packages.

    ppd1990 authored and whitequark committed Sep 11, 2019
  6. Fix undefined behavior in IdList::end().

    rpavlik authored and whitequark committed Sep 9, 2019
Commits on Sep 10, 2019
  1. Avoid undefined behavior from out-of-range access. NFC.

    rpavlik authored and whitequark committed Aug 21, 2019
  2. Remove extraneous semicolon. NFC.

    rpavlik authored and whitequark committed Aug 21, 2019
  3. Fix a comment. NFC.

    rpavlik authored and whitequark committed Aug 20, 2019
    Found by clang-tidy.
  4. Remove std::move from trivially-copyable types. NFC.

    rpavlik authored and whitequark committed Aug 20, 2019
    Found by clang-tidy
  5. Use IsEmpty() or .empty() to check if a container is empty. NFC.

    rpavlik authored and whitequark committed Aug 20, 2019
    Most found by clang-tidy.
  6. Fix TTF iteration in case of an empty list.

    rpavlik authored and whitequark committed Aug 20, 2019
  7. For loop cleanup. NFC.

    rpavlik authored and whitequark committed Aug 20, 2019
  8. Add and use List::Last(). NFC.

    rpavlik authored and whitequark committed Aug 20, 2019
  9. Use the same @todo hot comment style everywhere.

    whitequark committed Sep 10, 2019
  10. Fix use-after-free in revolve and helix.

    rpavlik authored and whitequark committed Sep 9, 2019
    Pointers get invalidated if a list has to be re-allocated.
    CopyEntity can do that.
  11. Fix a warning about a virtual destructor.

    rpavlik authored and whitequark committed Sep 10, 2019
  12. CLI/testsuite: do not crash if a dialog is displayed.

    rpavlik authored and whitequark committed Sep 10, 2019
Commits on Aug 25, 2019
  1. use std::vector in helix operations instead of fixed length array. Re…

    phkahler authored and whitequark committed Aug 24, 2019
    …move limit on number of sections. Delete definition of Revolved struct.
Commits on Aug 20, 2019
  1. Revert "IdList::RemoveTagged switch to std::remove_if from iteration.…

    rpavlik authored and whitequark committed Aug 20, 2019
    … NFC."
    
    This reverts commit 0bb6a34.
  2. Improve NextAfter. NFC.

    rpavlik authored and whitequark committed May 23, 2019
  3. Fix a manual manipulation of List::n. NFC.

    rpavlik authored and whitequark committed May 23, 2019
    This broke encapsulation and thus caused problems for any deeper changes
    to List.
  4. Add Last(). NFC.

    rpavlik authored and whitequark committed May 23, 2019
    Counterpart of First().  standard library calls this "back()".
  5. Improve Clear(). NFC.

    rpavlik authored and whitequark committed May 23, 2019
    Was getting segfaults near here with another patch since removed from the branch.
    Moving these assignments after the memfree means they still have
    useful data when debugging a crash in memfree.
  6. Improve MoveSelfInto. NFC.

    rpavlik authored and whitequark committed May 23, 2019
    std::swap is an idiomatic way to do a move.
  7. Add IdList::AllocForOneMore() based on List. NFC.

    rpavlik authored and whitequark committed May 23, 2019
    Also modifies a sizeof call.
  8. Improve implementation hiding in IdList/List. NFC.

    rpavlik authored and whitequark committed May 23, 2019
    Allows distancing users from the internal "elem" member.
    
    Add Get() and operator[].
    Replace direct references to elem.
    Make elem and elemsAllocated private in IdList/List.
  9. Replace qsort with std::sort and lambda. NFC.

    rpavlik authored and whitequark committed May 23, 2019
    Removes static variable usage, permits hiding of the underlying pointer
    (std::sort uses iterators intead), type safety, etc.
Older
You can’t perform that action at this time.