Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash with Unmatched regex #153

Closed
Evil-Spirit opened this issue Jan 12, 2017 · 7 comments
Closed

Crash with Unmatched regex #153

Evil-Spirit opened this issue Jan 12, 2017 · 7 comments
Assignees
Milestone

Comments

@Evil-Spirit
Copy link
Collaborator

System information

Appears after adding translations.
Windows 7 x64, MS VS 2013 compiler

Expected behavior

Should work

Actual behavior

Crash on running tests and running SolveSpace.exe

Additional information

File E:\SolveSpaceWork\solvespace_dxf\src\resource.cpp, line 488, function SolveSpace::ASCIIReader::ExpectRegex:
Assertion 'Unmatched regex' failed: ((TryRegex(re, m)) == false).

@whitequark whitequark added this to the 3.0 milestone Jan 12, 2017
@whitequark
Copy link
Contributor

This seems like an MSVC-related bug, or maybe \r\n issue. Can you look?

@Evil-Spirit
Copy link
Collaborator Author

@whitequark, OK

@lomatus
Copy link
Contributor

lomatus commented Jan 13, 2017

Vote +1
Appears when add new translation & non en_US region
Windows 7 x64/x86, MS VS 2015 compiler

@whitequark
Copy link
Contributor

I cannot reproduce this one myself with either MSVS2013 or MSVS2015, weird.

@lomatus would that be a zh_CN translation? I am very interested in that one.

@whitequark
Copy link
Contributor

Should be fixed in master.

@whitequark
Copy link
Contributor

@Evil-Spirit btw there is an unmerged ru_RU translation already, don't bother

@Evil-Spirit
Copy link
Collaborator Author

@whitequark, OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants