Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform generation in background #79

Closed
whitequark opened this issue Oct 14, 2016 · 1 comment
Closed

Perform generation in background #79

whitequark opened this issue Oct 14, 2016 · 1 comment

Comments

@whitequark
Copy link
Contributor

Ideally, generation would happen as follows: every time there is a change to the sketch, the sketch is copied, and a new background thread is spun up, which starts regenerating the sketch. The GUI is fully responsive during this. Once the background thread finishes, the sketch is moved back, in place of the one already owned by the GUI thread. If a new modification is made while the sketch is being regenerated, the thread is cancelled and a new one is spun up.

Unresolved questions: how do we handle incremental regeneration of e.g. a last group in a sketch with 40 groups, with a large mesh? This is potentially a lot of triangle copying. We could share some data but have to be really careful about it.

Depends on #78 (since right now there is only one Sketch ever).

@whitequark whitequark added this to the 3.0 milestone Oct 14, 2016
@whitequark whitequark removed this from the 3.0 milestone May 23, 2019
@phkahler
Copy link
Member

Given the complexity of this and the significant performance gains that have been made in recent years, I think it's time to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants