Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue1316 #1317

Merged
merged 3 commits into from Jan 2, 2023
Merged

Issue1316 #1317

merged 3 commits into from Jan 2, 2023

Conversation

phkahler
Copy link
Member

@phkahler phkahler commented Jan 2, 2023

Closes #1316. Fixes crashes on constraint creation. Fixes point H/V constraints. Fixes some undo/redo with constraints.

@77maxikov
Copy link
Contributor

I've lost one possible thing for multiple constraining - the case when several points coincide on

if(gs.points == 2 && gs.n == 2) {

@phkahler phkahler merged commit 105a350 into solvespace:master Jan 2, 2023
@phkahler
Copy link
Member Author

phkahler commented Jan 2, 2023

I've lost one possible thing for multiple constraining - the case when several points coincide on

if(gs.points == 2 && gs.n == 2) {

I fixed that. It should be on master. I also fixed points H/V which got broken, and I extended it to multiple points.

Try master now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contraints cause crash
2 participants