Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a crash when opening an empty file. #919

Merged
merged 2 commits into from Feb 3, 2021
Merged

Fix a crash when opening an empty file. #919

merged 2 commits into from Feb 3, 2021

Commits on Feb 1, 2021

  1. Fix a crash when opening an empty file. 

    Fixes: solvespace#918

The problem was that here:
https://github.com/solvespace/solvespace/blob/11a8a0abd5e21a0da6c818674f8b4b657a401a6c/src/file.cpp#L480
we cleared all groups. Then we tried to read an empty file and therefore this `while` exited immediately:
https://github.com/solvespace/solvespace/blob/11a8a0abd5e21a0da6c818674f8b4b657a401a6c/src/file.cpp#L487
and we came to here:
https://github.com/solvespace/solvespace/blob/11a8a0abd5e21a0da6c818674f8b4b657a401a6c/src/file.cpp#L548
where there was no `fileLoadError` and thus we were left with no groups, and so this assert failed:
https://github.com/solvespace/solvespace/blob/11a8a0abd5e21a0da6c818674f8b4b657a401a6c/src/graphicswin.cpp#L394
since is is not allowed to have no groups :-)
    @ruevs
    ruevs committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    248316a View commit details
    Browse the repository at this point in the history

  2. Update translations 

    Including de_DE and ru_RU strings.
    @ruevs
    ruevs committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    1b63467 View commit details
    Browse the repository at this point in the history