Add exportable option to default styles #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Primarily, this enables the user to export of construction entities in 2D views such as SVG. Previously constuction entities were always skipped. The "export these objects" is now available for all default styles. One may turn off export of constraints or the inactive groups for example. This also adds the exportable flag to the factory settings and support for saving the exportable option for default styles in the configuration. Construction entities with custom styles respect this option as well. NOTE: Running this version will add new entries to the configuration (Registry, .config etc.) on exit when testing this code.
Closed
|
Does this close #957 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primarily, this enables the user to export of construction entities in 2D views such as SVG and PDF as noted in #682. Previously construction entities were always skipped. The "export these objects" is now available for all default styles. One may turn off export of constraints or the inactive groups for example. Because export of construction entities is no longer blocked export option for custom styles also works for them.
This also adds the exportable flag to the factory defaults (so it can be reset) and support for saving the exportable option for default styles in the configuration. Construction entities with custom styles respect this option as well.
This also addresses a problem with missing contour fill for exported SVG.
To test this try exporting a sketch with construction entities. The default behavior is to skip them matching how SS behaves now. Then enable the export option for the construction entity style and re-export. You may also turn on/off other styles. Contour fill will now be exported for each style when exporting SVG
NOTE: Running this version will add new entries to the configuration (Registry, .config etc.) on exit when testing this code.