Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile errors in generated Java code #3

Closed
Reinhold- opened this issue Nov 19, 2013 · 6 comments
Closed

Compile errors in generated Java code #3

Reinhold- opened this issue Nov 19, 2013 · 6 comments

Comments

@Reinhold-
Copy link

The code generate from our ecore model contains compile errors in the webmapi.service.IdentificationResolver class.

I was able to fix this compile errors manually and get the REST api running. However, I would expect that the generated code contains no compile errors.

This zip file https://www.dropbox.com/s/flpavdwepdb9z8m/IdentificationResolver.zip contains two versions of the IdentificationResolver class. One version that the code generation produces and one version that I manually adjusted. When you make a diff of the two versions you can easily see the issues. The password for the zip file is "emf2rest".

Regards,
Reinhold

@ghost ghost assigned cadorca Nov 19, 2013
@cadorca
Copy link
Contributor

cadorca commented Nov 19, 2013

Hi Reinhold,

Thanks for your interest in EMF-Rest. This issue was fixed in the latest update. Please update the plugin and try gain. The version should be 201310211045.

Regards,
Camilo.

@Reinhold-
Copy link
Author

I get this issue again with EMF-REST 1.0.5.201311201139.
I get the compile errors in IdentificationResolver.java I reported in Issue #3.

e.g.
..
public static String getActionBaseId(toolconfiguration.ActionBase obj){
if(obj==null)
return null;

    return obj.getActive().toString();
}

..
Error: The method getActive() is undefined for the type ActionBase.

ActionBase has a method isActive() which returns a boolean value.

So the return statement should be something like
return String.valueOf(obj.isActive());

Cheers,
Reinhold

@Reinhold-
Copy link
Author

This issue should be reopened. However, it seems I do not have the rights to do so. Or The issue system of GitHub does not support reopening.

Cheers,
Reinhold

@jlcanovas jlcanovas reopened this Dec 2, 2013
@jlcanovas
Copy link
Member

Thanks for reporting this @Reinhold-, we'll work on that.

@jlcanovas
Copy link
Member

Need to check if this problem still applies to the last version

@jlcanovas jlcanovas assigned hamzaed and unassigned cadorca Sep 3, 2014
@hamzaed
Copy link
Collaborator

hamzaed commented Sep 3, 2014

Hi Reinhold,
The issue has been fixed in the last release. Please, update the plugin.

Cheers,
Hamza

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants