Add Slack tokens to docker-compose and added .env file template #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added SLACK_APP_TOKEN and SLACK_BOT_TOKEN as environment variables in the docker-compose.yml file. Additionally, renamed the smib/.env file to template.env and removed hardcoded token values. The README.md file was updated with instructions on how to set these tokens, and .env has been added to the .gitignore file to prevent accidental commits of the environment secrets.
Updated the README file to correct the command for setting Slack tokens as environment variables. This now accurately reflects the need to export both the SLACK_APP_TOKEN and SLACK_BOT_TOKEN for proper application functionality.
|
Env file for development
…On Mon, 29 Apr 2024, 19:43 Stephen Jefferson, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
On template.env
<#38 (comment)>:
@sam57719 <https://github.com/sam57719> I'm not overly familiar with the
environment variable passing. if we're exporting the variables as per the
readme setup, why do we need a .env file as well?
—
Reply to this email directly, view it on GitHub
<#38 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJZWKRVB6MLYCTA7M6KZGT3Y72IG5AVCNFSM6AAAAABG3O6XGCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMRZGMYDQMRZGA>
.
You are receiving this because you were mentioned.Message ID: <somakeit/S.
***@***.***>
|
This commit refines the guidance on setting Slack tokens as environment variables in the README file. It now supports and describes various methods, thus providing more flexibility for users to set up their environment.
…ctions # Conflicts: # docker-compose.yml
…ctions # Conflicts: # README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added SLACK_APP_TOKEN and SLACK_BOT_TOKEN as environment variables in the docker-compose.yml file. Additionally, renamed the smib/.env file to template.env and removed hardcoded token values. The README.md file was updated with instructions on how to set these tokens, and .env has been added to the .gitignore file to prevent accidental commits of the environment secrets.