-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make configuration directory configurable #109
Merged
sjefferson99
merged 5 commits into
develop
from
30-make-configuration-directory-configurable
May 29, 2024
Merged
Make configuration directory configurable #109
sjefferson99
merged 5 commits into
develop
from
30-make-configuration-directory-configurable
May 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for handling external configuration and log files. It modifies the configuration, Dockerfile, setup, and README to establish the paths and volumes for these files. It also enhances the logging setup to handle potential issues when loading configuration from an external JSON file.
The Dockerfile has been revised to better handle the logging.json file. It now removes the original logging.json file from the smib directory, and then repositions it to the appropriate container location, preventing potential issues when loading configuration data from an external source.
typo fix
network ports heading
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sam57719 Will test following the linux mount and local dev config location override and make sure docs work and make sense this evening.
sjefferson99
approved these changes
May 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.