56 dockerfile change to copy env file into the container #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored some modules in the configuration package and updated the Dockerfile to copy .env files if they exist. Paths are now more efficiently arranged and specific import statements have been added to improve code readability.
The commit streamlines handling of environment variables by removing their direct usage from docker-compose files. Instead of passing environment variables like SLACK_APP_TOKEN, SLACK_BOT_TOKEN, ME_CONFIG_BASICAUTH_USERNAME, and ME_CONFIG_BASICAUTH_PASSWORD from host to docker-compose files, now, .env files are directly copied into the Docker container if they exist. Also, the template.env and README.md files have been updated to reflect these changes.
The commit adds explicit file location details for 'logging.json' and '.env' in the README. The Docker volume paths have been updated in the Linux instructions. In addition, it provides an important note on mapping '/app/config' to a host directory which mandates adding the 2 external files to this location.
The commit enhances README by detailing the different methods to set environment variables. Emphasis has been made on the precedence of docker-compose environment variables over .env file variables. Clear instructions for placing and naming .env file have also been provided.
The commit refines the instructions for setting environment variables in the README.md file. It specifically emphasizes on the priority of 'docker-compose' environment variables over .env file's variables. More precise guidelines for creating and naming .env file are also included.
The commit refines the instructions for setting environment variables in the README.md file. It specifically emphasizes on the priority of 'docker-compose' environment variables over .env file's variables. More precise guidelines for creating and naming .env file are also included.
sjefferson99
deleted the
56-dockerfile-change-to-copy-env-file-into-the-container
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.