Update error handling in slack module #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swapped from using a list "ERRORS_TO_IGNORE" to a dictionary "ERROR_STATUSES" to handle error types more flexibly in the Slack module. Now, instead of simply ignoring certain errors, they are associated with appropriate HTTP status codes in the new dictionary. Any BoltUnhandledRequestError will now return a 404 Any Unhandled Exception in a plugin will return a 418 (I'm a TEAPOT)
sjefferson99
reviewed
May 1, 2024
The existing code that handled errors was refactored for better readability and efficiency. The class of the error is now captured in a variable, which is then used for logging and creating an appropriate response for unhandled error cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swapped from using a list "ERRORS_TO_IGNORE" to a dictionary "ERROR_STATUSES" to handle error types more flexibly in the Slack module. Now, instead of simply ignoring certain errors, they are associated with appropriate HTTP status codes in the new dictionary.
Any BoltUnhandledRequestError will now return a 404
Any Unhandled Exception in a plugin will return a 418 (I'm a TEAPOT)