Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat][resotocore] Implement aggregate over arrays #1780

Merged
merged 6 commits into from
Sep 26, 2023

Conversation

aquamatthias
Copy link
Member

Description

To-Dos

  • Add test coverage for new or updated functionality
  • Lint and test with tox

Code of Conduct

By submitting this pull request, I agree to follow the code of conduct.

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (cf5f015) 89.80% compared to head (5cb6dda) 89.84%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1780      +/-   ##
==========================================
+ Coverage   89.80%   89.84%   +0.03%     
==========================================
  Files          91       91              
  Lines       15417    15482      +65     
==========================================
+ Hits        13846    13910      +64     
- Misses       1571     1572       +1     
Flag Coverage Δ
resotocore 89.84% <97.36%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
resotocore/resotocore/cli/cli.py 91.83% <100.00%> (+0.06%) ⬆️
resotocore/resotocore/query/model.py 91.18% <100.00%> (+0.06%) ⬆️
resotocore/resotocore/query/query_parser.py 98.65% <100.00%> (ø)
resotocore/resotocore/db/arango_query.py 97.53% <98.36%> (+0.08%) ⬆️
resotocore/resotocore/report/inspector_service.py 91.16% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lloesche
lloesche previously approved these changes Sep 26, 2023
lloesche
lloesche previously approved these changes Sep 26, 2023
@aquamatthias aquamatthias merged commit 8afbdfa into main Sep 26, 2023
9 checks passed
@aquamatthias aquamatthias deleted the mv/aggregate_with_array branch September 26, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants