Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[azure] [feat] Add ResourceGroups and create edges from ResourceGroup to Resource #1782

Merged
merged 4 commits into from Oct 9, 2023
Merged

[azure] [feat] Add ResourceGroups and create edges from ResourceGroup to Resource #1782

merged 4 commits into from Oct 9, 2023

Conversation

1101-1
Copy link
Contributor

@1101-1 1101-1 commented Sep 25, 2023

Description

I have implemented the connect_in_graph method to establish a connection between AzureResourceGroup and AzureResource by creating an edge.

And I've included a test to validate this functionality and provided an example JSON for testing purposes.

To-Dos

  • Added method connect_in_graph to the resource group and test for collecting
  • Lint and test with tox

aquamatthias
aquamatthias requested changes Sep 25, 2023
View reviewed changes
Copy link
Member

@aquamatthias aquamatthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resources in the group are not fetched.
Also tox is red - PTAL.

plugins/azure/resoto_plugin_azure/resource/base.py Outdated Show resolved Hide resolved
@1101-1 1101-1 force-pushed the resource_group branch 2 times, most recently from 853f580 to 7962021 Compare October 6, 2023 15:58
aquamatthias
aquamatthias reviewed Oct 9, 2023
View reviewed changes
Copy link
Member

@aquamatthias aquamatthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor adjustment - otherwise, LGTM.

plugins/azure/resoto_plugin_azure/collector.py Outdated Show resolved Hide resolved
aquamatthias
aquamatthias approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@aquamatthias aquamatthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@aquamatthias aquamatthias merged commit 8614ef1 into someengineering:main Oct 9, 2023
5 checks passed
@1101-1 1101-1 deleted the resource_group branch October 10, 2023 12:12
@1101-1 1101-1 restored the resource_group branch October 10, 2023 12:13
@1101-1 1101-1 deleted the resource_group branch October 10, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aquamatthias aquamatthias aquamatthias approved these changes

@lloesche lloesche Awaiting requested review from lloesche lloesche is a code owner

@meln1k meln1k Awaiting requested review from meln1k meln1k is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@1101-1 @aquamatthias