Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[resotocore][feat] Maintain subscribers in memory #1819

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

aquamatthias
Copy link
Member

Description

To-Dos

  • Add test coverage for new or updated functionality
  • Lint and test with tox

Code of Conduct

By submitting this pull request, I agree to follow the code of conduct.

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5099152) 89.89% compared to head (73b02bc) 89.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1819      +/-   ##
==========================================
- Coverage   89.89%   89.84%   -0.05%     
==========================================
  Files          92       91       -1     
  Lines       15710    15686      -24     
==========================================
- Hits        14122    14093      -29     
- Misses       1588     1593       +5     
Flag Coverage Δ
resotocore 89.84% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
resotocore/resotocore/__main__.py 80.21% <100.00%> (ø)
resotocore/resotocore/db/db_access.py 82.41% <ø> (-0.27%) ⬇️
resotocore/resotocore/task/subscribers.py 75.55% <100.00%> (-1.48%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aquamatthias aquamatthias merged commit 28a13a6 into main Nov 9, 2023
8 checks passed
@aquamatthias aquamatthias deleted the mv/persistent_subscriptions branch November 9, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants