Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[resotocore][fix] Make list column unique #1826

Merged
merged 2 commits into from Nov 16, 2023
Merged

Conversation

aquamatthias
Copy link
Member

Description

To-Dos

  • Add test coverage for new or updated functionality
  • Lint and test with tox

Code of Conduct

By submitting this pull request, I agree to follow the code of conduct.

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (b8d575c) 89.84% compared to head (1eac374) 89.84%.
Report is 1 commits behind head on main.

❗ Current head 1eac374 differs from pull request most recent head ed955b8. Consider uploading reports for the commit ed955b8 to get more accurate results

Files Patch % Lines
resotocore/resotocore/cli/command.py 90.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1826   +/-   ##
=======================================
  Coverage   89.84%   89.84%           
=======================================
  Files          91       91           
  Lines       15721    15751   +30     
=======================================
+ Hits        14125    14152   +27     
- Misses       1596     1599    +3     
Flag Coverage Δ
resotocore 89.84% <90.62%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aquamatthias aquamatthias merged commit b29356b into main Nov 16, 2023
6 checks passed
@aquamatthias aquamatthias deleted the mv/unique-list-column branch November 16, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants