Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[azure] [feat] Filter virtual machine sizes #1852

Merged
merged 7 commits into from Dec 21, 2023
Merged

[azure] [feat] Filter virtual machine sizes #1852

merged 7 commits into from Dec 21, 2023

Conversation

1101-1
Copy link
Contributor

@1101-1 1101-1 commented Dec 7, 2023

Description

Objective:

Filter virtual machine sizes to retain only those associated with existing virtual machines.

To-Dos

  • Filter virtual machine sizes to collect it correctly
  • Delete unnecessary network resource
  • Add test coverage for new or updated functionality
  • Lint and test with tox

Code of Conduct

By submitting this pull request, I agree to follow the code of conduct.

aquamatthias
aquamatthias requested changes Dec 19, 2023
View reviewed changes
Copy link
Member

@aquamatthias aquamatthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filtering is fine - thanks. One small comment on region handling.

I also stumbled upon fetch_resouces. All usages of this method are not required, since the related data is already available in the graph. Please remove this method and rework the usage.

plugins/azure/resoto_plugin_azure/resource/compute.py Show resolved Hide resolved
plugins/azure/resoto_plugin_azure/resource/network.py Outdated Show resolved Hide resolved
plugins/azure/resoto_plugin_azure/resource/network.py Outdated Show resolved Hide resolved
plugins/azure/resoto_plugin_azure/resource/network.py Outdated Show resolved Hide resolved
plugins/azure/resoto_plugin_azure/resource/network.py Outdated Show resolved Hide resolved
plugins/azure/resoto_plugin_azure/resource/network.py Outdated Show resolved Hide resolved
plugins/azure/resoto_plugin_azure/resource/network.py Outdated Show resolved Hide resolved
plugins/azure/resoto_plugin_azure/resource/network.py Outdated Show resolved Hide resolved
aquamatthias
aquamatthias reviewed Dec 20, 2023
View reviewed changes
Copy link
Member

@aquamatthias aquamatthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One request to rename first and second lambdas to something more intuitive. Otherwise lgtm.

plugins/azure/resoto_plugin_azure/resource/network.py Outdated Show resolved Hide resolved
plugins/azure/resoto_plugin_azure/resource/compute.py Show resolved Hide resolved
@aquamatthias aquamatthias merged commit 77d3b95 into someengineering:main Dec 21, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aquamatthias aquamatthias aquamatthias approved these changes

@lloesche lloesche Awaiting requested review from lloesche lloesche is a code owner

@meln1k meln1k Awaiting requested review from meln1k meln1k is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@1101-1 @aquamatthias