[resotocore][fix] Benchmark should not have a dot in the name (#1493)

someengineering · Mar 10, 2023 · be9a34c · be9a34c
1 parent 9ce3d71
commit be9a34c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/resotocore/resotocore/report/inspector_service.py b/resotocore/resotocore/report/inspector_service.py
@@ -63,7 +63,10 @@ def __init__(self, cli: CLI) -> None:
     async def start(self) -> None:
         # TODO: we need a migration path for checks added in existing configs
         config_ids = {i async for i in self.config_handler.list_config_ids()}
-        overwrite = True  # only here to simplify development. True until we reach a stable version.
+        overwrite = False  # only here to simplify development. True until we reach a stable version.
+        # we renamed this config in 3.2.6 - old installations still might have it
+        # this line can be removed in a future version
+        await self.config_handler.delete_config(ConfigId("resoto.report.benchmark.aws_cis_1.5"))
         for name, js in BenchmarkConfig.from_files().items():
             if overwrite or benchmark_id(name) not in config_ids:
                 cid = benchmark_id(name)

diff --git a/...tic/report/benchmark/aws/aws_cis_1.5.json → ...tic/report/benchmark/aws/aws_cis_1_5.json b/...tic/report/benchmark/aws/aws_cis_1.5.json → ...tic/report/benchmark/aws/aws_cis_1_5.json