Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws][feat] Define remaining AWS EC2 resources #1007

Merged
merged 16 commits into from
Jul 13, 2022
Merged

[aws][feat] Define remaining AWS EC2 resources #1007

merged 16 commits into from
Jul 13, 2022

Conversation

aquamatthias
Copy link
Member

Description

Model, mapping and test for:

  • elastic ips
  • network interfaces
  • vpc
  • subnets
  • security groups
  • nat gateways
  • internal gateways
  • snapshots
  • vpc peering connections
  • vpc endpoints
  • route tables

To-Dos

  • Add test coverage for new or updated functionality
  • Lint and test with tox

Issues Fixed

  • Fixes #XXXX

Code of Conduct

By submitting this pull request, I agree to follow the code of conduct.

# Conflicts:
#	plugins/aws/resoto_plugin_aws/resource/ec2.py
#	plugins/aws/test/collector_test.py
meln1k
meln1k previously approved these changes Jul 13, 2022
Copy link
Member

@meln1k meln1k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aquamatthias aquamatthias merged commit 4589439 into main Jul 13, 2022
@aquamatthias aquamatthias deleted the mv/ec2_rest branch July 13, 2022 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants