Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding a timeout to the Geth systemd configurations #6

Closed
burz opened this issue Nov 16, 2022 · 1 comment
Closed

Consider adding a timeout to the Geth systemd configurations #6

burz opened this issue Nov 16, 2022 · 1 comment

Comments

@burz
Copy link

burz commented Nov 16, 2022

Hey @SomerEsat, I have found your guides very helpful!

An issue I have run into with Geth is that the proposed systemd configuration file uses the default timeout when shutting down. Since Geth sometimes can take quite a while to write its state to disk, this can lead to bad shutdowns (as systemd simply kills Geth after the default timeout) that corrupt Geth's state. This can often take hours or days to fix (I have for example recently seen it have to go back in history and start redownloading the state from over 1 week and 4 days ago).

Therefore, I think it might be helpful to add the TimeoutStopSec=600 variable in the Geth systemd configuration (i.e. a timeout of 10 minutes) so that Geth should almost certainly have enough time to write to disk before it is killed (as eluded to here for example: ethereum/go-ethereum#24416).

Thanks again for all you do for the space!

@SomerEsat
Copy link
Owner

Hey @burz,

Added the timeout after consulting with a Geth dev (here) and verifying the config change doesn't break the existing service.

All guides have been updated.

Thanks for the suggestion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants