Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing ISR_ATTR to methods called from isrs #98

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

arneboe
Copy link
Contributor

@arneboe arneboe commented Aug 25, 2023

Add some isr attrs that where missing and causing crashes when cache was disabled.

Copy link
Owner

@someweisguy someweisguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised that the static inline functions were causing crashes. They're supposed to be inlined to avoid cache crashes. :(

Excellent catch on dmx_driver_is_installed(). I feel like a dummy for missing it! :)

@someweisguy someweisguy merged commit ea5bae6 into someweisguy:release/v3.1 Aug 25, 2023
@arneboe
Copy link
Contributor Author

arneboe commented Aug 25, 2023

I am not sure if the static inlines where the problem.
I followed all methods from the isr callbacks and added the attribute. Could very well be that only the dmx_driver_is_installed was the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants