Allow for ignore file globs #731
Conversation
Codecov Report
@@ Coverage Diff @@
## main #731 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 28 +2
Lines 445 455 +10
Branches 82 85 +3
=========================================
+ Hits 445 455 +10
Continue to review full report at Codecov.
|
| @@ -4,3 +4,4 @@ dist/ | |||
| obj/ | |||
| report/ | |||
| yarn-error.log | |||
| _quokka.js | |||
There was a problem hiding this comment.
Just so I could save my quokka-ing :)
| @@ -2,5 +2,4 @@ | |||
| "editor.formatOnSave": true, | |||
| "javascript.validate.enable": false, | |||
| "typescript.validate.enable": false, | |||
| "jest.pathToConfig": "./jest.config.js", | |||
There was a problem hiding this comment.
I'm using Wallaby now :)
| "pre-commit": [ | ||
| "pretty-quick", | ||
| "lint", | ||
| "test" | ||
| ] |
There was a problem hiding this comment.
We have github actions now, we don't really need this overhead. Also, the linting was linting files that were not staged, which just got in the way.
This adds the ignore file example, which doesn't work yet, and updates the integration tests to run with __examples__ as the working directory
somewhatabstract
force-pushed
the
somewhatabstract/issue636
branch
from
a017b3c
to
165b214
Compare
Summary:
This updates the
--ignore-filesoption to support globs so that we can do things like"**/lint-disallowlist.txt"to get all disallow lists in the tree that is being synced.This also ensures that ignore rules loaded from these files are applied based on the path of the ignore file to avoid ignoring things they aren't meant to.
Issue: #636
Test plan:
yarn test