-
Notifications
You must be signed in to change notification settings - Fork 51
Conversation
That's interesting! |
@seb86 thanks for the PR 👍 I will give this a better look and get back to you asap :) |
@franticpsyx you are right! The override is possible for the composite container. Indeed if you have optional components you are not able to forecast a price for the container. With percentage discount it is possible to overcome this limitation :) |
It's a start in the right direction. |
I think I would prefer a Discount field, since that would allow the defined price override to be applicable to Bundles/Composites, as well - support for these extensions was a major motivation for coding this plugin in the first place. On the other hand, discounts sometimes make it hard to get an exact price.
I'd take (1) over (2). Not sure if we should have both. Thoughts? @jconroy ;) |
@franticpsyx I think we could add both depending on the type of product that is created. |
@franticpsyx A simple product could have the option to choose either price or discount while other types of products would only have the one option. |
@franticpsyx Would the discount be a flat-rate or a percentage of the regular price? |
Percentage off the price of the product, so that it can propagate down to any dependent (bundled/composited/...) cart items. We could use a filter to determine whether the % discount is calculated off the regular or the sale price (if it exists). |
@seb86 a quick update about this - we are planning to work on some SATT-related tasks in a few days, and this is definitely on my to-do list :) |
@franticpsyx Great. Let me know if you need any help. |
@seb86 @franticpsyx We think that this is a great feature!! It would be perfect for our needs. Let me know if you need any beta testing. We like your idea as well about the discount being a flat-rate or % off the regular price. Since the regular price will be multiplied by the number of weeks, months, days, etc.. of the subscription it could be applied to any length of time and provide accurate prices. We look forward to your work. |
@seb86 @franticpsyx Also can you add a div class to the Subscription Prompt text box so that I can be customized with css? Thanks |
@furchildpets Which prompt text box are you referring to? |
@seb86 The Subscription Prompt field provided. See the attached image... I learned that you can add html there so I created my own div class, but it would be better if was in the page template. I have done so css customization and this is the result... |
@furchildpets Just added two action hooks that you can use to customize the subscription prompt area. Hope that helps. |
@seb86 Ok great!!! Thanks |
Hello @seb86 @franticpsyx You probably know this already but wanted to let you know that the subscription prices add on to the fixed / base price of the composite product instead of overriding the Total Price. You can see an example here.... Also when you build your composite product and price products individually the subscription price adds on to those as well. So no matter what you put in your Subscription Prices they do not override the Total Price field of the composite product. This leads me to think that should be two modes for the Subscription Prices;
Well, once again let me know if I can be of any help - beta testing, etc... Thanks Paul |
@furchildpets Thank you for your feedback. We will look into this. |
Hi everyone, as a shop owner that mini extension is exactly what I am hoping to do with subs. But as you mentioned being able to change the price for each subs scheme is vital. I understand the advantage of % discount but I think an option to obtain a clean round price is important (either with a fixed price that overrides, or better a fixed discount (compatible with bundles and composites)) |
@seb86 Can you have a look at the https://github.com/Prospress/woocommerce-subscribe-to-all-the-things/tree/issue-13-patches branch? @louis2b We will do both. See https://github.com/Prospress/woocommerce-subscribe-to-all-the-things/tree/issue-13-patches and let us know if you find any issues :) Haven't tested it thoroughly with Bundles + Composites under all price-overriding scenarios, so if you notice anything strange let me know. Thanks! |
@franticpsyx I will try to find some time over the weekend but I will need access to your bundles and composites plugin repositories. Would you be able to do that? |
Hi @franticpsyx thanks for the update, I have tested the extension with bundle products, I noticed a few problems.
Hope that helps ! Let me know if I was not clear |
@franticpsyx Thanks for the updated release and pointing me in the right direction. We really appreciate your continuing work on this extension. I have tested this with our dev site with Product Bundles and it is working better, but there is one BIG problem, that I believe @louis2b has seen as well... The correct price and total go into the cart page, but not into the Cart Widget in the Header. It has the original product price when you add any subscription value. After you refresh the cart page or go to another site page the cart widget price changes and reflects the subscription override price. I have turned off woocommerce > settings > ajax cart updates and the same thing happens. Before adding item to the cart... Product Bundle with original price.... Override Product - 2 Subscription levels - one with sale price... Display on Product page... Subscription Product added to Cart. Cart Widget price updates with Orginal Price not Subscription price.... However Cart Totals are correct... When the page is refreshed or you go to another site page the Cart Widget reflects the correct price... Our Cart Widget is part of the standard Woocommerce integration into the Mill Theme. No customization there. Any ideas why it is not reflecting the correct price when the product is first added? Thanks, P |
@louis2b @furchildpets Thanks for the feedback - there is still some work to do on that branch, for instance related to the mini-cart issue. A couple other issues will be harder to fix - for instance, Bundles compatibility with discounts / price overrides and per-item priced Bundles will take some time but it's definitely on my to-do list. 👍 |
@franticpsyx Your welcome -- for us if we can just get the mini-cart issue solved then we have enough to go live. All of our product bundles are set prices and the override product price is working well. Something interesting to note... when we activate the WooCommerce Cart Tab plugin -- Plugin LInk - https://wordpress.org/plugins/woocommerce-cart-tab/ As a work around I am thinking about forcing the visitor to the Cart page after adding a product and then hiding the Cart value via css display:none; on just that specific page. When they go to any other site page the Mini Cart reflects the correct price total. The bundles compatibility with price overrides - reg. and sale are working well for us. Thanks again. |
I have added the option to enter a price per subscription option.
Here are some screenshots to show the changes. https://cloudup.com/calXMRYWl-m
I look forward to your feedback.