Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]wikidataid is not unique and labels are not handled as lists #54

Closed
WolfgangFahl opened this issue Aug 11, 2021 · 1 comment
Closed
Assignees

Comments

@WolfgangFahl
Copy link
Collaborator

Describe the bug
The wikidataid for countries, regions and cities should be unique there might be multiple labels but not multiple entries under the same id

To Reproduce
use primarykey of pyLoDStorage

Expected behavior
Primary key should be set and index should be automatically created.

WolfgangFahl added a commit that referenced this issue Aug 11, 2021
WolfgangFahl added a commit that referenced this issue Aug 12, 2021
@WolfgangFahl
Copy link
Collaborator Author

0:Arlington County (None - None)
1:Rincón (None - None)
2:Happy Valley-Goose Bay (None - None)
3:St. Petersburg (None - None)
4:Abele (None - None)
======================================================================
FAIL: testCityManagerFromJSONBackup (tests.test_location.TestLocationHierarchy)
tests the loading and parsing of the cityList form the json backup file
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/wf/Documents/pyworkspace/geograpy3/tests/test_location.py", line 262, in testCityManagerFromJSONBackup
    citiesByWikiDataId=self.checkNoDuplicateWikidataIds(cityManager)
  File "/Users/wf/Documents/pyworkspace/geograpy3/tests/test_location.py", line 195, in checkNoDuplicateWikidataIds
    self.assertEqual(len(duplicates),0)
AssertionError: 5 != 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants