Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing declaration file when using with typescript in strict mode #49

Closed
sonallux opened this issue Apr 9, 2020 · 0 comments · Fixed by #54
Closed

Missing declaration file when using with typescript in strict mode #49

sonallux opened this issue Apr 9, 2020 · 0 comments · Fixed by #54
Labels
bug Something isn't working

Comments

@sonallux
Copy link
Owner

sonallux commented Apr 9, 2020

When using this library in a typescript project with strict mode turned on, the ts compiler complains about missing declaration file semver/classes/semver. The error is caused because we import SemVer in our types.d.ts. The declaration (@types/semver) is specified as dev dependency, so they are not present when using release-script.

There are two possible solutions for this problem

  • Move the @types/semver from devDependencies to dependencies
  • Include the definitions for SemVer in our types.d.ts
@sonallux sonallux added the bug Something isn't working label Apr 9, 2020
@sonallux sonallux changed the title Missing external declarations when using with typescript in strict mode Missing declaration file when using with typescript in strict mode Apr 9, 2020
@sonallux sonallux mentioned this issue Apr 13, 2020
Merged
@sonallux sonallux linked a pull request Apr 13, 2020 that will close this issue
Bump semver from 7.2.1 to 7.2.2 #54
Merged
sonallux pushed a commit that referenced this issue Apr 13, 2020
@dependabot-preview
Change semver version in package.json to version range (#54)
81e11db 
- Change semver version in package.json to version range
- Fixes #49 
- Reverts changes from #36
- Add timeout to workflow
sonallux pushed a commit that referenced this issue Dec 1, 2020
@dependabot-preview
Change semver version in package.json to version range (#54)
3717ffa 
- Change semver version in package.json to version range
- Fixes #49 
- Reverts changes from #36
- Add timeout to workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump semver from 7.2.1 to 7.2.2 sonallux/release-script
1 participant
@sonallux