Skip to content
This repository has been archived by the owner on Jan 30, 2023. It is now read-only.

Update paths and file name according to documentation #45

Closed
wants to merge 4 commits into from

Conversation

stefanerwinmayer
Copy link

@mwz
Copy link
Member

mwz commented Aug 18, 2019

Thanks for your PR @stefanerwinmayer.
This change would improve the integration with SonarScala, but it would break it for sonar-scala, which uses a different set of properties for scoverage and scapegoat. To make this work for both Scala plugins, we could use both sets of properties and automatically set them all (so in addition to the new properties that you added I'd also keep the old ones). This might result in sbt-sonar showing warnings about setting unused properties when running analysis using both SonarScala and sonar-scala (we'd need to check that it's not an error), but at least it's a quick way to make this work for both plugins. @BalmungSan does that sound ok to you?

@BalmungSan
Copy link

I think we either should change sonar-scala to have the same flags. Or to add a flag / setting to this plugin to indicate which sonar plugin one is using.

I prefer the last.

@mwz
Copy link
Member

mwz commented Aug 18, 2019

add a flag / setting to this plugin to indicate which sonar plugin one is using

Yes, that would also be my preferred option 👍 I'd like to keep sonar-scala as the default option for compatibility reasons, but you could toggle a flag to switch over to SonarScala compatible properties. I'm trying to come up with any good names, but the best I've got so far is sonarUseCommunityPlugin which defaults to true and setting it to false toggles SonarScala compatibility. Can you think of any better alternatives?

@BalmungSan
Copy link

BalmungSan commented Aug 18, 2019

I am really bad at naming things, and I liked yours. Thus, no more alternatives from my side.

@mwz
Copy link
Member

mwz commented Oct 13, 2019

Hi @stefanerwinmayer, does the solution I proposed above make sense to you? Is that something you would be able to contribute as a part of this PR?

@stefanerwinmayer
Copy link
Author

Hi @stefanerwinmayer, does the solution I proposed above make sense to you? Is that something you would be able to contribute as a part of this PR?

Yes I will do that.

@mwz
Copy link
Member

mwz commented Jul 5, 2020

Superseded by #117.

@mwz mwz closed this Jul 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants