Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime checks for samples causes a lot of false positives for short runtime shows #7086

Closed
1 task done
Tenno6 opened this issue Aug 12, 2024 · 3 comments · Fixed by #7094
Closed
1 task done

Runtime checks for samples causes a lot of false positives for short runtime shows #7086

Tenno6 opened this issue Aug 12, 2024 · 3 comments · Fixed by #7094

Comments

@Tenno6
Copy link

Tenno6 commented Aug 12, 2024

Is there an existing issue for this?

  • I have searched the existing open and closed issues

Current Behavior

Currently media that include episodes with low runtimes wont import due to being detected as a sample.

Expected Behavior

Either take into account the type of show (cartoons with short episodes ex. Looney Tunes) to disable sample detection or either a global sample runtime detection setting or individual setting per show.

Steps To Reproduce

  1. Fetch episode with low runtime
  2. Sonarr fails to import

Environment

- OS: unraid
- Sonarr: 4.0.8.1874
- Docker Install: Yes
- Using Reverse Proxy: No
- Browser: N/A
- Database: Sqlite 3.45.3

What branch are you running?

Main

Trace Logs?

N/A

Anything else?

No response

@markus101
Copy link
Member

Please provide the required logs of a rejection so we can see more information about it.

@Tenno6
Copy link
Author

Tenno6 commented Aug 12, 2024

2024-08-12 08:46:34.7|Debug|DetectSample|[/downloads/usenet/completed/tv/Looney.Tunes.S1937E36.September.in.the.Rain.DVDRip.AC3.x264/Looney.Tunes.S1937E36.September.in.the.Rain.DVDRip.AC3.x264.mkv] appears to be a sample. Runtime: 00:04:39.2790000 seconds. Expected at least: 300 seconds

@bakerboy448
Copy link
Contributor

Impact/frequency seems like it'd be isolated to one or two shows that release episodes in a per file per short format.....most or almost all of these types of releases will end up as several shorts together in one file.

Seems like work to resolve what manual import for the handful of shows / releases would occur

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants