Disable ssllabs rule by default
#355
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ssllabs` rule takes quite a lot of time to complete, so for users that don't know that, it might seem like things are stuck. So, for the time being, don't include the `ssllabs` rule by default, only if the user specifically requested it.
molant
approved these changes
Jul 3, 2017
alrra
added a commit
that referenced
this pull request
Jul 3, 2017
The `ssllabs` rule takes quite a lot of time to complete, so for users that don't know that, it might seem like things are stuck. For the reason mentioned above, for the time being, don't include the `ssllabs` rule by default, only if the user specifically requested it. - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - Close #355
alrra
added a commit
that referenced
this pull request
Jul 13, 2017
The `ssllabs` rule takes quite a lot of time to complete, so for users that don't know that, it might seem like things are stuck. For the reason mentioned above, for the time being, don't include the `ssllabs` rule by default, only if the user specifically requested it. - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - Close #355
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ssllabsrule takes quite a lot of time to complete, so for users that don't know that, it might seem like things are stuck.For the reason mentioned above, for the time being, don't include the
ssllabsrule by default, only if the user specifically requested it.Ref: #354 (comment)